Page 1 of 1
Small patch about compilation and method name
Posted: Sun Dec 21, 2008 8:20 pm
by jfouche
Hi
Here is my first patch :
- fixed : VolumeLocatorThread compilation problem
- updated : IManager::AddFilesToVirtualFolder instead of IManager::AddFilesToVirtualFodler
The second one is maybe not a good idea, because it's changing a usefull header file interface, but I prefere to have a correct method name... As you want.
Thanks
Re: Small patch about compilation and method name
Posted: Sun Dec 21, 2008 10:22 pm
by eranif
jfouche wrote:The second one is maybe not a good idea, because it's changing a usefull header file interface, but I prefere to have a correct method name... As you want.
This is why I have plugin_version.h file.
Whenever an interface is modified, this file should be incremented by 1 - so at runtime, codelite can query the plugin about its interface version
Code: Select all
// Increment this number whenever any of the files in the interface project is modified
#define PLUGIN_INTERFACE_VERSION 131
Eran
Re: Small patch about compilation and method name
Posted: Sun Dec 21, 2008 10:24 pm
by jfouche
Understood
Re: Small patch about compilation and method name
Posted: Sun Dec 21, 2008 10:52 pm
by eranif
If you have wxUSE_FSVOLUME defined in your source code, this patch will break the compilation.
The reason for this:
You should test for wxUSE_FSVOLUME *after* the include files, since this define is defined in a header file (wx/setup.h)
If you place it ontop of the file, it will be tested before it had the chance to be defined, so it will be handled like #if 0
However, in FileExplorer, you test it after the include statements, so it is not defined as 1 -> which leads to link error.
Anyways, I fixed it and committed the patch.
Eran
Re: Small patch about compilation and method name
Posted: Sun Dec 21, 2008 11:00 pm
by jfouche
I agree
I have to say that I do not have wxUSE_FSVOLUME = 1, compiling wxWidgets 2.8.9 with mingw32-make. I'm a little bit surprised !