Should I submit patches for wx-config-win.cpp here?

Discussion about CodeLite development process and patches
stahta01
CodeLite Curious
Posts: 9
Joined: Thu Dec 29, 2011 10:07 pm
Genuine User: Yes
IDE Question: C++
Contact:

Should I submit patches for wx-config-win.cpp here?

Post by stahta01 » Sun Dec 29, 2013 5:13 am

FYI:

I am working on patches to wx-config-win.cpp used to create wx-config.exe for Windows users.
Should I submit them here or somewhere else?
If you know the correct place please respond with link to it.

I am guessing upstream is here https://code.google.com/p/wx-config-win/; but, it looks old to me.

Tim S.

User avatar
eranif
CodeLite Plugin
Posts: 6122
Joined: Wed Feb 06, 2008 9:29 pm
Genuine User: Yes
IDE Question: C++
Contact:

Re: Should I submit patches for wx-config-win.cpp here?

Post by eranif » Sun Dec 29, 2013 12:09 pm

Hi Tim, the one you mentioned is quite old and not maintained.

I have a forked version (which I maintain for several years now) in codelite's git - look under codelite-sources/sdk/wxconfig/

My version contains various fixes / improvements such as :
supporting more libraries (the std keywords contains "rich" library and others)
paths are using forward slashes (caused problems when using wx-config.exe under MSYS/Cygwin)
Better support for monolithic version of wxWidgets
and other fixes I made over the years which I can't remember now ;)

So you might not need your patches, just have a look if it works with codeite's wx-config.exe

Eran
Make sure you have read the HOW TO POST thread

stahta01
CodeLite Curious
Posts: 9
Joined: Thu Dec 29, 2011 10:07 pm
Genuine User: Yes
IDE Question: C++
Contact:

Re: Should I submit patches for wx-config-win.cpp here?

Post by stahta01 » Tue Dec 31, 2013 4:57 pm

I have modified the wx-config to better support static and monolithic wxWidgets configuration.
Also, added "richtext" Library name in addition to the prior "rich".

Tim S.
You do not have the required permissions to view the files attached to this post.

User avatar
eranif
CodeLite Plugin
Posts: 6122
Joined: Wed Feb 06, 2008 9:29 pm
Genuine User: Yes
IDE Question: C++
Contact:

Re: Should I submit patches for wx-config-win.cpp here?

Post by eranif » Tue Dec 31, 2013 5:32 pm

Thanks, patch applied

Eran
Make sure you have read the HOW TO POST thread

stahta01
CodeLite Curious
Posts: 9
Joined: Thu Dec 29, 2011 10:07 pm
Genuine User: Yes
IDE Question: C++
Contact:

Re: Should I submit patches for wx-config-win.cpp here?

Post by stahta01 » Thu Jan 02, 2014 12:19 am

Found an issue building CodeLite; not sure if it counts as bug or not.

You have "--wxcfg=gcc_dll/mswu" or "--wxcfg=gcc_dll/mswud" in two spots in LiteEditor.project this resulted in my wxcfg environmental var being override.

Tim S.
You do not have the required permissions to view the files attached to this post.

stahta01
CodeLite Curious
Posts: 9
Joined: Thu Dec 29, 2011 10:07 pm
Genuine User: Yes
IDE Question: C++
Contact:

Re: Should I submit patches for wx-config-win.cpp here?

Post by stahta01 » Fri Jan 03, 2014 4:08 am

Found a mistake in my wx-config patch. It fails to work right when user defines wxUSE_GUI=0 and wxWidgets has USE_GUI=1.
(This is happens when the wxWidgets console sample is compiled.)
The value of wxUSE_STC is still one. Normally this causes no problem; but, when wxWidgets was compiled with USE_GUI and without USE_STC it gives wrong results (tries to link to missing library). Should not cause a problem in other cases.

Tim S.

Code: Select all

diff --git a/sdk/wxconfig/wx-config-win.cpp b/sdk/wxconfig/wx-config-win.cpp
index 8dd311d..7e2f745 100644
--- a/sdk/wxconfig/wx-config-win.cpp
+++ b/sdk/wxconfig/wx-config-win.cpp
@@ -686,7 +686,7 @@ public:
         /// External libs (to wxWidgets)
 
         if (cfg["USE_GUI"] == "1")
-            if (sho["wxUSE_STC"])
+            if (cfg["USE_STC"] == "1" )
                 po["__LIB_WXSCINTILLA_p"] = addLib("wxscintilla" + po["WXDEBUGFLAG"]);
 
         if (cfg["USE_GUI"] == "1")

User avatar
eranif
CodeLite Plugin
Posts: 6122
Joined: Wed Feb 06, 2008 9:29 pm
Genuine User: Yes
IDE Question: C++
Contact:

Re: Should I submit patches for wx-config-win.cpp here?

Post by eranif » Fri Jan 03, 2014 1:32 pm

Thanks, both patches applied

Eran
Make sure you have read the HOW TO POST thread

Post Reply