Thoughts about CodeLite's appearance, themes/colorschemes

[SoleSoul]

I love the attention to details.
To test the new changes what do I need to do? recompile from git?

[eranif]

Yes, just pull from git head
Note that I only tested on Windows ( but I can assure you that linux compiles, I just compiled it over SSH)
Eran

[NilC]

I made hack-fix for colours in new build tab.

[eranif]

I made hack-fix for colours in new build tab.

Did you test it?

IIRC, wxDataViewCtrl does not happy with customized background colours (this is the control codelite is using for the build output)
The fix you made only changed the text colour, but not the background colour

I am trying other methods now - but I am pretty sure they will fail

Eran

[eranif]

I made hack-fix for colours in new build tab.

IIRC, wxDataViewCtrl does not happy with customized background colours (this is the control codelite is using for the build output)
The fix you made only changed the text colour, but not the background colour

I am trying other methods now - but I am pretty sure they will fail

Eran

[NilC]

Did you test it?

It's works for me on Windows 7 x64, wxWidgets-2.9.4 - with codelite patches.

[eranif]

Strange, I am using the exact same configuration (Windows 7x64) and the results does not look the same, I will keep on checking

Eran

[eranif]

I found the cause of the confusion:
We had different starting points: my initial theme was the "default", while yours was "Zmrok" or "DarkTheme"
So when I changed the theme, the editor + workspace view did change their colors but not the output view (it would have updated the colours if I had restarted my codelite)

This is because the theme change did not went through the "ThemeHandler" class.
I reverted your patch and moved it to the "ThemeHandler" class - it now works

I will commit it as soon as I will run some more tests
Eran

[NilC]

Nice!

And yes, I undertand that my patch is ugly (so i named it hack-fix), cause code that responsible for theme colours (and other theme stuff) must be placed in one module (for now it's ThemeHandler class, I guess), not scattered to 9000 modules.

[eranif]

I committed my fixes to git head.
It should now be able to update *all* output pane windows ( the debugger pane is still not handled )

Eran