PATCH: No reposition editor after add watch
Posted: Sun Sep 12, 2010 9:49 am
Per bug 3059778 reported by me on SourceForge CodeLite bug tracker, patch offered.
Code: Select all
UpdateFileLine(event.m_file, event.m_line, ManagerST::Get()->GetRepositionEditor());
Code: Select all
UpdateFileLine(event.m_file, event.m_line, true);
Could the system be setup to raise a flag when the debugger starts called "m_debuggerHasRestarted" and a count called "m_debuggerCallbacks" indicating how many times it's been "activated" through an error or through a user stepping since the start of the debugger session? That way it could be tested the first time RefreshValues() is called and always force the refresh. It may also provide interesting / useful statistics (debugger cycles, debugger up-time, efficiency, etc.).eranif wrote:I found a regression using this patch:
If I start a new debug sessions while I already have 'watches' from the previous debug session, codelite does not show the green arrow. I have to manually click on the 'Show Current Line' button in the debugger tool.
The interaction with the debugger is done in an async mode. A counter can be added, but I'd rather use it only for statistics.foxmuldr wrote:Could the system be setup to raise a flag when the debugger starts called "m_debuggerHasRestarted" and a count called "m_debuggerCallbacks" indicating how many times it's been "activated" through an error or through a user stepping since the start of the debugger session? That way it could be tested the first time RefreshValues() is called and always force the refresh. It may also provide interesting / useful statistics (debugger cycles, debugger up-time, efficiency, etc.).
This sounds like a better alternative, I will give it a tryfoxmuldr wrote:In the alternative, here's a patch which only calls RefreshValues(false) from OnNewWatch() and OnDisplayFormat(), and from cl_editor.cpp when the user right-clicks or selects the menu to add a watch. Everywhere else uses the default/old RefreshValues() functionality, which forces the full editor position refresh.
Was this patch ever applied?eranif wrote:This sounds like a better alternative, I will give it a try
the original patch yes, the latest one: not yet. I will apply it on my local copy and test it as soon as I find some spare timefoxmuldr wrote:Was this patch ever applied?