Should I submit patches for wx-config-win.cpp here?

[stahta01]

FYI:

I am working on patches to wx-config-win.cpp used to create wx-config.exe for Windows users.
Should I submit them here or somewhere else?
If you know the correct place please respond with link to it.

I am guessing upstream is here https://code.google.com/p/wx-config-win/; but, it looks old to me.

Tim S.

[eranif]

Hi Tim, the one you mentioned is quite old and not maintained.

I have a forked version (which I maintain for several years now) in codelite's git - look under codelite-sources/sdk/wxconfig/

My version contains various fixes / improvements such as :
supporting more libraries (the std keywords contains "rich" library and others)
paths are using forward slashes (caused problems when using wx-config.exe under MSYS/Cygwin)
Better support for monolithic version of wxWidgets
and other fixes I made over the years which I can't remember now

So you might not need your patches, just have a look if it works with codeite's wx-config.exe

Eran

[stahta01]

I have modified the wx-config to better support static and monolithic wxWidgets configuration.
Also, added "richtext" Library name in addition to the prior "rich".

Tim S.

[eranif]

Thanks, patch applied

Eran

[stahta01]

Found an issue building CodeLite; not sure if it counts as bug or not.

You have "--wxcfg=gcc_dll/mswu" or "--wxcfg=gcc_dll/mswud" in two spots in LiteEditor.project this resulted in my wxcfg environmental var being override.

Tim S.

[stahta01]

Found a mistake in my wx-config patch. It fails to work right when user defines wxUSE_GUI=0 and wxWidgets has USE_GUI=1.
(This is happens when the wxWidgets console sample is compiled.)
The value of wxUSE_STC is still one. Normally this causes no problem; but, when wxWidgets was compiled with USE_GUI and without USE_STC it gives wrong results (tries to link to missing library). Should not cause a problem in other cases.

Tim S.

Code: Select all

diff --git a/sdk/wxconfig/wx-config-win.cpp b/sdk/wxconfig/wx-config-win.cpp
index 8dd311d..7e2f745 100644
--- a/sdk/wxconfig/wx-config-win.cpp
+++ b/sdk/wxconfig/wx-config-win.cpp
@@ -686,7 +686,7 @@ public:
         /// External libs (to wxWidgets)
 
         if (cfg["USE_GUI"] == "1")
-            if (sho["wxUSE_STC"])
+            if (cfg["USE_STC"] == "1" )
                 po["__LIB_WXSCINTILLA_p"] = addLib("wxscintilla" + po["WXDEBUGFLAG"]);
 
         if (cfg["USE_GUI"] == "1")

[eranif]

Thanks, both patches applied

Eran